[0.67] Implement importantForAccessibility="no-hide-accessibility" #10280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
TatianaKapos
changed the title
agniuks
approved these changes
Jul 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backporting #9898 to resolve #9977. Tested with an example app to confirm fix.
Type of Change
Erase all that don't apply.
Why
Implement importantForAccessibility="no-hide-accessibility". When specified on a view-based component should remove accessibility for the element itself and its descendants.
Resolves #5113
What
Recursively apply accessible={false} prop to children of view-based component.
Attempted implementation used by Garrison team but it was not sufficient for Desktop, as focusable elements were still focusable even after being removed from the UIA tree.
Testing
Tested in playground with multiple configurations of nested components.
Optional: Describe the tests that you ran locally to verify your changes.
Microsoft Reviewers: Open in CodeFlow
Microsoft Reviewers: Open in CodeFlow