Adds QuirkSetting to use YGExperimentalFeatureWebFlexBasis #10661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, Yoga will cache flex basis values to avoid expensive recomputation. However, there are some scenarios, particularly when resizing the window, where cached layout values from Yoga combined with cached flex basis values can produce incorrect results. This change adds a new QuirkSetting to opt-in to the YGExperimentalFeatureWebFlexBasis option in Yoga for apps where re-use of this cached flex basis value is problematic. We'll keep this opt-in for now, as it is likely to impact performance of Yoga layout. Resolves microsoft#9343
jonthysell
requested changes
Oct 5, 2022
Contributor
jonthysell
left a comment
jonthysell
left a comment
There was a problem hiding this comment.
Fix the copy paste typo, then good to go.
ghost
added
the
Needs: Author Feedback
jonthysell
approved these changes
Oct 6, 2022
Contributor
|
@msftbot please delay 6 hours before merging this |
ghost
added
the
AutoMerge
|
Hello @jonthysell! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Erase all that don't apply.
Why
By default, Yoga will cache flex basis values to avoid expensive recomputation. However, there are some scenarios, particularly when resizing the window, where cached layout values from Yoga combined with cached flex basis values can produce incorrect results.
Resolves #9343
What
This change adds a new QuirkSetting to opt-in to the YGExperimentalFeatureWebFlexBasis option in Yoga for apps where re-use of this cached flex basis value is problematic. We'll keep this opt-in for now, as it is likely to impact performance of Yoga layout.
Testing
CI is green. Results of opting into this QuirkSetting may vary in different apps both w.r.t. to performance and potentially layout results.