Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Test Access-Control-Request-Headers (#11031)",
"packageName": "react-native-windows",
"email": "jurocha@microsoft.com",
"dependentChangeType": "patch"
}
52 changes: 52 additions & 0 deletions vnext/Desktop.UnitTests/OriginPolicyHttpFilterTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -4,19 +4,28 @@
#include <CppUnitTest.h>

#include <Networking/OriginPolicyHttpFilter.h>
#include <Networking/WinRTTypes.h>
#include "WinRTNetworkingMocks.h"

// Windows API
#include <winrt/Windows.Foundation.Collections.h>
#include <winrt/Windows.Web.Http.h>

using namespace Microsoft::VisualStudio::CppUnitTestFramework;
using namespace winrt::Windows::Web::Http;

using Microsoft::React::Networking::OriginPolicyHttpFilter;
using Microsoft::React::Networking::RequestArgs;
using Microsoft::React::Networking::ResponseOperation;
using winrt::Windows::Foundation::Uri;

namespace Microsoft::React::Test {

TEST_CLASS (OriginPolicyHttpFilterTest) {
TEST_CLASS_INITIALIZE(Initialize) {
winrt::uninit_apartment();
}

// TEMP tests to see if Uri has comparison capabilities
TEST_METHOD(UrlsHaveSameOrigin) {
// clang-format off
Expand Down Expand Up @@ -242,6 +251,49 @@ TEST_CLASS (OriginPolicyHttpFilterTest) {
Assert::AreEqual(2, static_cast<int>(response.Headers().Size()));
}
}

TEST_METHOD(ValidatePreflightResponseMainAndContentHeadersSucceeds) {
auto mockFilter = winrt::make<MockHttpBaseFilter>();
mockFilter.as<MockHttpBaseFilter>()->Mocks.SendRequestAsync =
[](HttpRequestMessage const &request) -> ResponseOperation {
HttpResponseMessage response{};

response.StatusCode(HttpStatusCode::Ok);
response.Headers().Insert(L"Access-Control-Allow-Origin", L"*");
// Return allowed headers as requested by client
response.Headers().Insert(
L"Access-Control-Allow-Headers", request.Headers().Lookup(L"Access-Control-Request-Headers"));

co_return response;
};

auto reqArgs = winrt::make<RequestArgs>();
auto request = HttpRequestMessage(HttpMethod::Get(), Uri{L"http://somehost"});
request.Properties().Insert(L"RequestArgs", reqArgs);
request.Headers().TryAppendWithoutValidation(L"Authorization", L"Bearer abc");
// Should implicitly set Conent-Length and Content-Type
request.Content(HttpStringContent{L"PreflightContent"});

auto filter = winrt::make<OriginPolicyHttpFilter>(mockFilter);
auto opFilter = filter.as<OriginPolicyHttpFilter>();

OriginPolicyHttpFilter::SetStaticOrigin("http://somehost");
try {
auto sendOp = opFilter->SendPreflightAsync(request);
sendOp.get();

auto response = sendOp.GetResults();
opFilter->ValidatePreflightResponse(request, response);

OriginPolicyHttpFilter::SetStaticOrigin({});
Assert::AreEqual(
L"Authorization, Content-Length, Content-Type",
response.Headers().Lookup(L"Access-Control-Allow-Headers").c_str());
} catch (const winrt::hresult_error &e) {
OriginPolicyHttpFilter::SetStaticOrigin({});
Assert::Fail(e.message().c_str());
}
}
};

} // namespace Microsoft::React::Test
2 changes: 2 additions & 0 deletions vnext/Shared/Networking/OriginPolicyHttpFilter.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,8 @@ bool OriginPolicyHttpFilter::ConstWcharComparer::operator()(const wchar_t *a, co
/*static*/ void OriginPolicyHttpFilter::SetStaticOrigin(std::string &&url) {
if (!url.empty())
s_origin = Uri{to_hstring(url)};
else
s_origin = nullptr;
}

/*static*/ bool OriginPolicyHttpFilter::IsSameOrigin(Uri const &u1, Uri const &u2) noexcept {
Expand Down