[0.71] Backport #10969: Implement rowGap, columnGap and gap flex properties #11194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Implement rowGap, columnGap and gap flex properties * Change files
Member
Author
|
@acoates-ms Speak up if there's any reason not to backport this |
acoates-ms
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backporting #10969
0.71 brings in new support for rowGap, columnGap and gap flex properties. This hooks up the new properties.
Type of Change
Why
Feature was added in core 0.71 but the RNW change didn't make 0.71.0
Testing
Original verification
New verification
Patched files into an app that uses
gapand ensured layout was modified.Ran in RNTester to verify gap test:
Microsoft Reviewers: Open in CodeFlow