Skip to content

[0.72] Test HttpServer build fix #12064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JunielKatarn merged 5 commits into from
Sep 2, 2023
Merged

[0.72] Test HttpServer build fix #12064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5ac50c1
Test HttpServer build fix (#12001)
acoates-ms Aug 10, 2023
23403f3
Remove change files
JunielKatarn Aug 24, 2023
0d33388
Change files
JunielKatarn Aug 24, 2023
931f672
Merge branch '0.72-stable' into backports/12001-72
JunielKatarn Aug 29, 2023
690f2a8
Merge branch '0.72-stable' into backports/12001-72
JunielKatarn Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-ecffcdea-9308-4776-838d-e7e504c267da.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Test HttpServer build fix (#12001)",
"packageName": "react-native-windows",
"email": "julio.rocha@microsoft.com",
"dependentChangeType": "patch"
}
2 changes: 1 addition & 1 deletion vnext/Microsoft.ReactNative/CoreApp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ static void SetProperties(JsonObject const &json, RNCoreApp *app) {
std::wstring nsName;
std::wstring localName;
if (lastDot != name.rend()) {
nsName = std::wstring{name.begin(), static_cast<uint64_t>(name.rend() - lastDot - 1)};
nsName = std::wstring{name.begin(), static_cast<size_t>(name.rend() - lastDot - 1)};
localName = std::wstring{lastDot.base()};
} else {
localName = name;
Expand Down
6 changes: 3 additions & 3 deletions vnext/Test/HttpServer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,8 +283,8 @@ void HttpSession::Close()

#pragma region HttpServer

HttpServer::HttpServer(string &&address, uint16_t port, size_t concurrency)
: m_ioThreadCount{concurrency}
HttpServer::HttpServer(string &&address, uint16_t port, int concurrency)
: m_ioThreadCount{ static_cast<size_t>(concurrency) }
, m_ioContext{concurrency}
, m_acceptor{make_strand(m_ioContext)}
{
Expand Down Expand Up @@ -319,7 +319,7 @@ HttpServer::HttpServer(string &&address, uint16_t port, size_t concurrency)
}
}

HttpServer::HttpServer(uint16_t port, size_t concurrency)
HttpServer::HttpServer(uint16_t port, int concurrency)
: HttpServer("0.0.0.0", port, concurrency)
{
}
Expand Down
4 changes: 2 additions & 2 deletions vnext/Test/HttpServer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,8 @@ class HttpServer : public std::enable_shared_from_this<HttpServer>
// address - Valid IP address string (i.e. "127.0.0.1).
// port - TCP port number (i.e. 80).
///
HttpServer(std::string &&address, uint16_t port, size_t concurrency = 1);
HttpServer(uint16_t port, size_t concurrency = 1);
HttpServer(std::string &&address, uint16_t port, int concurrency = 1);
HttpServer(uint16_t port, int concurrency = 1);

~HttpServer();

Expand Down