[Fabric] Move E2E fabric app to WinAppSDK and lifted composition #12242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoates-ms
changed the title
| require('@rnw-scripts/babel-node-config'), | ||
| ]; | ||
|
|
||
| const appWorkingDir = 'windows\\x64\\Release\\RNTesterApp-Fabric'; |
Contributor
There was a problem hiding this comment.
I think this path should be 'windows\x64\Release\' instead. I believe that should fix the issue.
Closed
…can be loaded before the instance
jonthysell
approved these changes
Oct 26, 2023
packages/e2e-test-app-fabric/windows/RNTesterApp-Fabric/RNTesterApp-Fabric.cpp
Show resolved
Hide resolved
Contributor
|
Is there an issue/tracking updating the new app template to use WinAppSDK? |
jonthysell
added
the
New Architecture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Microsoft Reviewers: Open in CodeFlow