Update app template's metro config with latest upstream changes #12279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR applies the changes we need to an app's metro config on top of a more recent snap of the default metro config for an RN app. Resolves: microsoft#12268
jonthysell
added
Breaking Change
TatianaKapos
approved these changes
Oct 20, 2023
jonthysell
added a commit
to jonthysell/react-native-windows
that referenced
this pull request
Oct 20, 2023
This PR backports microsoft#12279 to 0.73. This PR applies the changes we need to an app's metro config on top of a more recent snap of the default metro config for an RN app. Resolves: microsoft#12268
jonthysell
added a commit
that referenced
this pull request
Oct 23, 2023
#12280) This PR backports #12279 to 0.73. ## Description This PR applies the changes we need to an app's metro config on top of a more recent snap of the default metro config for an RN app. ### Type of Change - Bug fix (non-breaking change which fixes an issue) - Breaking change (fix or feature that would cause existing functionality to not work as expected) - ### Why To fix new apps not loading because of a badly configured bundle. Resolves: #12268 ### What Coped the current RN template metro.config.js and applied our changes. ## Screenshots N/A ## Testing Verified a new app loads correctly ## Changelog Should this change be included in the release notes: yes Update app template's metro config with latest upstream changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR applies the changes we need to an app's metro config on top of a more recent snap of the default metro config for an RN app.
Type of Change
Why
To fix new apps not loading because of a badly configured bundle.
Resolves: #12268
What
Coped the current RN template metro.config.js and applied our changes.
Screenshots
N/A
Testing
Verified a new app loads correctly
Changelog
Should this change be included in the release notes: yes
Update app template's metro config with latest upstream changes
Microsoft Reviewers: Open in CodeFlow