Fabric: Add windows script to new cpp-app template #12374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the functionality for apps created with the new cpp-app template to run `yarn windows`, as an alias for `react-native run-windows`, similar to the old template. To do this, I've created a new `templateUtils` module for shared template config code, with a new `updateProjectPackageJson()` method to make it easy for templates to inject items into a project's package.json file (in this case, a new `scripts` entry).
jonthysell
added a commit
to jonthysell/react-native-windows
that referenced
this pull request
Nov 10, 2023
The upstream RN app template includes a jest test suite (run with `yarn test`) with a default test to render your app JS using the `react-test-renderer`. However, this only tests the iOS version of your app (it forces platform === 'ios') and therefore won't catch if there are issues in your `windows` platform files. Using `@rnx-kit/jest-preset`, you can run jest tests against any platform via a custom jest config. This PR adds `@rnx-kit/jest-preset` as a dev dependency to the new `cpp-app` template, as well as a `jest.config.windows.js` to use it. Furthermore it adds a script so users can run these tests for windows via `yarn test:windows`. To support this, I've extended the templateUtils added in microsoft#12374 to include functionality to run `npm i` / `yarn` to install any new dependencies added. Closes microsoft#11939
chiaramooney
approved these changes
Nov 13, 2023
jonthysell
added a commit
to jonthysell/react-native-windows
that referenced
this pull request
Nov 13, 2023
The upstream RN app template includes a jest test suite (run with `yarn test`) with a default test to render your app JS using the `react-test-renderer`. However, this only tests the iOS version of your app (it forces platform === 'ios') and therefore won't catch if there are issues in your `windows` platform files. Using `@rnx-kit/jest-preset`, you can run jest tests against any platform via a custom jest config. This PR adds `@rnx-kit/jest-preset` as a dev dependency to the new `cpp-app` template, as well as a `jest.config.windows.js` to use it. Furthermore it adds a script so users can run these tests for windows via `yarn test:windows`. To support this, I've extended the templateUtils added in microsoft#12374 to include functionality to run `npm i` / `yarn` to install any new dependencies added. Closes microsoft#11939
jonthysell
added
the
New Architecture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds the functionality for apps created with the new cpp-app template to run
yarn windows, as an alias forreact-native run-windows, similar to the old template.To do this, I've created a new
templateUtilsmodule for shared template config code, with a newupdateProjectPackageJson()method to make it easy for templates to inject items into a project's package.json file (in this case, a newscriptsentry).Type of Change
Why
Adds a useful feature of the old templates to the new template
What
See above.
Screenshots
N/A
Testing
Verified creating a new project works.
Changelog
Should this change be included in the release notes: yes
The new Fabric app template now supports
yarn windowsas an alias toreact-native run-windowsMicrosoft Reviewers: Open in CodeFlow