Update fmt version to 10.1.0 #12411
Merged
Update fmt version to 10.1.0 #12411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoates-ms
approved these changes
Nov 16, 2023
Closed
jonthysell
pushed a commit
to jonthysell/react-native-windows
that referenced
this pull request
May 2, 2024
This PR backports microsoft#12411 to 0.71. * update fmt to 10.1.0 * Change files
jonthysell
added a commit
that referenced
this pull request
May 2, 2024
This PR backports #12411 to 0.71. * update fmt to 10.1.0 * Change files Co-authored-by: Marlene Cota <mcota@microsoft.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Why
MSVC is deprecating stdext::checked_array_iterator which fmt was using and caused build breaks when we updated to VS 17.8.
Resolve #12407
What
Updating to fmt 10.1.0 since it removes all stdext::checked_array_iterator references. (fmtlib/fmt#3540)
Also removing current workaround of silencing the warning.
Testing
fmt.vcxproj now builds with VS 17.8
Changelog
Should this change be included in the release notes: yes
Update fmt version from 8.0.0 to 10.1.0
Microsoft Reviewers: Open in CodeFlow