[Fabric] Handle scale factor changes #13406
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlenecota
approved these changes
Jul 2, 2024
microsoft-github-policy-service
bot
added
the
Invalid Triage
acoates-ms
added a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Jul 3, 2024
* [Fabric] Handle scalefactor changes * Change files
acoates-ms
added a commit
that referenced
this pull request
Jul 8, 2024
* [Fabric] Patch yoga to include changes to correctly recalculate layout on scale change (#13407) * Patch yoga to handle dynamic scale changes * Change files * Update vnext/overrides.json Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com> * Update vnext/overrides.json Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com> * Update vnext/overrides.json Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com> * Update vnext/overrides.json Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com> * Update vnext/overrides.json Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com> * Update vnext/ReactCommon/TEMP_UntilReactCommonUpdate/yoga/yoga/config/Config.cpp Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com> * Update vnext/ReactCommon/TEMP_UntilReactCommonUpdate/yoga/yoga/config/Config.h Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com> * Update vnext/ReactCommon/TEMP_UntilReactCommonUpdate/yoga/yoga/config/Config.h Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com> * Update vnext/ReactCommon/TEMP_UntilReactCommonUpdate/yoga/yoga/node/LayoutResults.cpp Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com> * Update vnext/ReactCommon/TEMP_UntilReactCommonUpdate/yoga/yoga/node/LayoutResults.h Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com> * review feedback from yoga PR --------- Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com> * [Fabric] Handle scale factor changes (#13406) * [Fabric] Handle scalefactor changes * Change files * change file fix * update overrides to align with 0.74 --------- Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com>
microsoft-github-policy-service
bot
added
the
New Architecture
acoates-ms
added a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Jul 16, 2024
* [Fabric] Handle scalefactor changes * Change files
acoates-ms
added a commit
that referenced
this pull request
Aug 1, 2024
* [Fabric] Patch yoga to include changes to correctly recalculate layout on scale change (#13407) * Patch yoga to handle dynamic scale changes * Change files * Update vnext/overrides.json Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com> * Update vnext/overrides.json Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com> * Update vnext/overrides.json Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com> * Update vnext/overrides.json Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com> * Update vnext/overrides.json Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com> * Update vnext/ReactCommon/TEMP_UntilReactCommonUpdate/yoga/yoga/config/Config.cpp Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com> * Update vnext/ReactCommon/TEMP_UntilReactCommonUpdate/yoga/yoga/config/Config.h Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com> * Update vnext/ReactCommon/TEMP_UntilReactCommonUpdate/yoga/yoga/config/Config.h Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com> * Update vnext/ReactCommon/TEMP_UntilReactCommonUpdate/yoga/yoga/node/LayoutResults.cpp Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com> * Update vnext/ReactCommon/TEMP_UntilReactCommonUpdate/yoga/yoga/node/LayoutResults.h Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com> * review feedback from yoga PR --------- Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com> * [Fabric] Handle scale factor changes (#13406) * [Fabric] Handle scalefactor changes * Change files * [Fabric] Handle changes to BorderRadius (#13422) * Handle changes to borderradius * Change files * format * [Fabric] [Win32] Add image response APIs to win32 exports (#13428) * Add image response APIs to win32 exports * Change files * fix * [Fabric] Move to WinAppSDK types for KeyStatus, and ensure usages account for locked flag (#13435) * [Fabric] Move to WinAppSDK types for KeyStatus, and ensure usages account for locked flag * Change files * Use scrollEnabled flag to enable/disable the ScrollView (#13427) * Fix scrollview * Change files * Address feedback * Return false for scroll event handlers when scroll is disabled * Update scrollbar color based on scrollEnabled * Rename OnThemeChanged to UpdateColorForScrollBarRegions * [Fabric] Fix image component reference cycle (#13440) * [Fabric] Fix image component reference cycle * Change files * format * disable aggressive component deleted assert * Use weak_ref for image didReceiveImage callback * typo * Unsubscribe from imageresponseobserver when deleted - aligns with core * format * [Fabric] call reportMount to implement UIManagerMountHook support (#13443) * [Fabric] call reportMount to implement UIManagerMountHook support * Change files * Resolve Transform Matrix before Animation (#13450) * Resolve transform before animation * Change files * Minor naming fix * noexcept * [Fabric] Text renders borders twice (#13445) * [Fabric] Text renders borders twice * Change files * Add fabric test for text borders * snapshot updates * snapshots * align overrides for 0.75 branch * snapshot --------- Co-authored-by: Marlene Cota <1422161+marlenecota@users.noreply.github.com> Co-authored-by: Sharath Manchala <10109130+sharath2727@users.noreply.github.com>
jonthysell
removed
the
Invalid Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently fabric apps do not handle DPI scale changes well.
This change ensures that we listen to scale changes from the ContentIsland and that text is re-rendered at the correct scale factor.
However, to get good scale change behavior we will also need a fix in yoga: facebook/yoga#1674
Microsoft Reviewers: Open in CodeFlow