Skip to content

[Fabric] Text renders borders twice #13445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acoates-ms merged 5 commits into from
Jul 16, 2024
Merged

[Fabric] Text renders borders twice #13445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9c49ee9
[Fabric] Text renders borders twice
acoates-ms Jul 15, 2024
d3931c7
Change files
acoates-ms Jul 15, 2024
35d625b
Add fabric test for text borders
acoates-ms Jul 15, 2024
961d149
snapshot updates
acoates-ms Jul 16, 2024
fee1554
snapshots
acoates-ms Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/react-native-windows-63f67386-8c58-4d24-88c1-84e80443b8d4.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "[Fabric] Text renders borders twice",
"packageName": "react-native-windows",
"email": "30809111+acoates-ms@users.noreply.github.com",
"dependentChangeType": "patch"
}
8 changes: 6 additions & 2 deletions packages/@react-native-windows/tester/src/js/examples/Text/TextExample.windows.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,7 +979,9 @@ function TextBaseLineLayoutExample(props: {}): React.Node {

function TextBorderExample(props: {}): React.Node {
return (
<View testID={'text-border'}>
<View testID={'text-border'}
accessible
accessibilityLabel="Border Example">
<Text style={styles.borderedTextSimple}>
Sample bordered text with default styling.
</Text>
Expand Down Expand Up @@ -1009,7 +1011,9 @@ function TextBorderExample(props: {}): React.Node {

function AdvancedBordersExample(props: {}): React.Node {
return (
<View testID={'advanced-borders'}>
<View testID={'advanced-borders'}
accessible
accessibilityLabel="Advanced Border Example">
<Text
style={{
borderColor: 'red',
Expand Down
12 changes: 12 additions & 0 deletions packages/e2e-test-app-fabric/test/TextComponentTest.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,4 +99,16 @@ describe('Text Tests', () => {
const dump = await dumpVisualTree('text-shadow');
expect(dump).toMatchSnapshot();
});
test('Text can have borders', async () => {
const component = await app.findElementByTestID('text-border');
await component.waitForDisplayed({timeout: 5000});
const dump = await dumpVisualTree('text-border');
expect(dump).toMatchSnapshot();
});
test('Text can have advanced borders', async () => {
const component = await app.findElementByTestID('advanced-borders');
await component.waitForDisplayed({timeout: 5000});
const dump = await dumpVisualTree('advanced-borders');
expect(dump).toMatchSnapshot();
});
});
Loading