Add support for accessibilityPosInSet and accessibilitySetSize to Fabric #13518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Area: Accessibility
Area: ActivityIndicator
Area: Component Views
Area: Fabric
sharath2727
reviewed
Aug 1, 2024
| accessibilityLabel="Press to submit your application!" | ||
| accessibilityRole="Button" | ||
| accessibilityHint="Submit Button" | ||
| accessibilityPosInSet={1} |
Contributor
There was a problem hiding this comment.
Should we also add these to: \vnext\src-win\Libraries\Components...?
Contributor
Author
There was a problem hiding this comment.
No that won't be needed because these are just the example files, not the actual source! The examples live in packages/@rnw and the source for the button control lives in vnext/src-win...
acoates-ms
approved these changes
Aug 5, 2024
acoates-ms
pushed a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Aug 30, 2024
…ric (microsoft#13518) * Add Support for AccessibilityPosInSet * Change files * Format * Add testing * Fix Missing TestID * Add Props to Accessibility Tree Dumps * Update Fabric Snapshots * Update Touchable Example * Update Snapshotes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Why
Add support for accessibilityPosInSet and accessibilitySetSize to Fabric.
Resolves #13077
Resolves #13086
Resolves #12512
Resolves #12511
Resolves #13093
Resolves #13092
Resolves #13090
Resolves #13089
Resolves #13087
Resolves #13084
Resolves #13081
Resolves #13080
Resolves #13078
Resolves #13079
Resolves #13088
What
Testing
Check setting and removing both props on View control. Will validate which other controls also automatically work before merging. Test exists in E2E testing to track data stored in UIA tree.
Changelog
Should this change be included in the release notes: yes
Add support for
accessibilityPosInSetandaccessibilitySetSizeto Fabric.