[Fabric] Rework custom components to not rely on open compose patterns #13603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlenecota
reviewed
Aug 27, 2024
| // in Microsoft.ui.xaml.controls.dll. | ||
| auto playgroundApp{winrt::make<winrt::Playground::implementation::App>()}; | ||
| #endif | ||
| // auto playgroundApp{winrt::make<winrt::Playground::implementation::App>()}; |
Contributor
There was a problem hiding this comment.
Is this temporarily commented out?
Contributor
Author
There was a problem hiding this comment.
It caused a runtime error trying to create the XamlApplication object. I commented this out for now so that I could use USE_EXPERIMENTAL_WINUI3 to verify the content island hosting component.
Someone will have to look into how to properly get Xaml working within a fabric application.
jonthysell
approved these changes
Aug 29, 2024
acoates-ms
added a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Aug 30, 2024
microsoft#13603) * Rework custom components to not rely on open compose patterns * Change files * fix * fix * handle non-visual children * fix * fix * Move delegates to builder instead of exposing them directly from the ComponentViews * fix
acoates-ms
added a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Aug 30, 2024
microsoft#13603) * Rework custom components to not rely on open compose patterns * Change files * fix * fix * handle non-visual children * fix * fix * Move delegates to builder instead of exposing them directly from the ComponentViews * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rework how custom components are defined to avoid using inheritance across the dll boundary.
Also added basic support for hosting ContentIslands within RNW. -- This requires using the experimental versions of WinAppSDK to work though.
Why
cppwinrt does not support open composition across dll boundaries.
What
Essentially all overridable methods have become either events, or settable delegates.
Microsoft Reviewers: Open in CodeFlow