[Fabric] Fix ScrollViewComponentView object leak #13633
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acoates-ms
added a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Aug 30, 2024
* [Fabric] Fix ScrollViewComponentView object leak * Change files * fix * fix * Update CompositionEventHandler.cpp * fix
acoates-ms
added a commit
to acoates-ms/react-native-windows
that referenced
this pull request
Aug 30, 2024
* [Fabric] Fix ScrollViewComponentView object leak * Change files * fix * fix * Update CompositionEventHandler.cpp * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ScrollViewComponentView's are currently leaking when used. This fixes the ref cycle between the ScrollView and the ScrollBars. I also added a new command to playground-composition to unload the instance which helps debug leak issues.
Microsoft Reviewers: Open in CodeFlow