Switch to optimized text #13647
Merged
Switch to optimized text #13647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Does this PR fix the accessibility in Fabric issues as mentioned in the original bug? |
Contributor
Author
|
@jonthysell yes! When merging, it overwrote the default accessible value for windows, so added that back in and marked it as a windows change so it doesn't get changed in the future. |
jonthysell
approved these changes
Sep 5, 2024
marlenecota
reviewed
Sep 5, 2024
| onStartShouldSetResponder != null) && | ||
| _disabled !== true; | ||
|
|
||
| // TODO: Move this processing to the view configuration. |
Contributor
There was a problem hiding this comment.
Is there an issue tracking this TODO?
Contributor
Author
There was a problem hiding this comment.
This is from upstream!
marlenecota
reviewed
Sep 5, 2024
acoates-ms
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches to use new optimized Text.js since upstream deprecated the older version!
Type of Change
Why
Resolves #13579
Changelog
no