Skip to content

Conversation

@Yajur-Grover
Copy link
Contributor

@Yajur-Grover Yajur-Grover commented Jan 27, 2025

@TatianaKapos
Copy link
Contributor

TatianaKapos commented Apr 22, 2025

Catching up on this PR and making sure everything is documented here, blocked from #14133, which says we needs an updated version of hermes that has microtask functionality. Running rn-tester Fabric hits this assert:

@Yajur-Grover Yajur-Grover marked this pull request as ready for review May 7, 2025 00:13
@Yajur-Grover Yajur-Grover requested review from a team as code owners May 7, 2025 00:13
Copy link
Contributor

@anupriya13 anupriya13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think snapshot update is required for E2ETestApp Fabric and conflict resolutions

@anupriya13 anupriya13 requested a review from a team May 7, 2025 06:10
Copy link
Contributor

@chiaramooney chiaramooney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good just left one comment to check on before merging

@acoates-ms acoates-ms enabled auto-merge (squash) May 7, 2025 21:06
@acoates-ms acoates-ms merged commit 10017d2 into microsoft:main May 7, 2025
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add default case to facebook::react::displayModeToInt()

5 participants