Added support for keyboard modifiers to mouse/touch events. #1693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rozele
reviewed
Mar 5, 2018
| pointer.ShiftKey = Window.Current.CoreWindow.GetKeyState(Windows.System.VirtualKey.Shift).HasFlag(CoreVirtualKeyStates.Down); | ||
| pointer.AltKey = Window.Current.CoreWindow.GetKeyState(Windows.System.VirtualKey.Menu).HasFlag(CoreVirtualKeyStates.Down); | ||
| pointer.CtrlKey = Window.Current.CoreWindow.GetKeyState(Windows.System.VirtualKey.Control).HasFlag(CoreVirtualKeyStates.Down); | ||
| } |
Contributor
There was a problem hiding this comment.
Do we want to implement this key or add an API for core window keyboard events to JavaScript? I guess the concern with doing it in JavaScript is that it's asynchronous (something could get out of sync between the keyboard state and the click event)
Contributor
Author
There was a problem hiding this comment.
Yes, I followed the "stamp the modifier keys at event creation moment" pattern.
If by API you mean a notification pipe from native to JS that keeps some JS state in sync with the kbd state, I just didn't think the complexity would warrant the perf gain.
In reply to: 172177315 [](ancestors = 172177315)
rozele
approved these changes
Mar 5, 2018
ladipro
pushed a commit
to ladipro/react-native-windows
that referenced
this pull request
May 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.