Add flag to enable building with chakra core on uwp #2630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stecrain
requested review from
acoates-ms,
ahimberg,
akrantz,
licanhua and
mganandraj
ghost
added
the
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
acoates-ms
approved these changes
Jun 17, 2019
Contributor
acoates-ms
left a comment
acoates-ms
left a comment
There was a problem hiding this comment.
You'll need to merge my latest checkin to get build verification. (sorry I broke the non-fork RN slice earlier)
Contributor
Author
No worries. TY for the quick review! |
stecrain
added
the
AutoMerge
|
Hello @stecrain! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
akrantz
reviewed
Jun 18, 2019
| return fwrite(&val, 1, file) == 1; | ||
| } | ||
|
|
||
| #if !defined(CHAKRACOREUWP) |
Contributor
There was a problem hiding this comment.
I would like to suggest making the define CHAKRACORE_UWP.
Contributor
Author
There was a problem hiding this comment.
whoops. did catch this comment before the automerge. I'll send a follow-up renaming this
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out there is already a mechanism to import react.overrides.props from the consuming app.
The idea is adding the property true in react.overrides.props to allow building with chakracore.
Microsoft Reviewers: Open in CodeFlow