Skip to content

Added image sample and fixed a couple bugs #2649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
3 commits merged into from
Jun 20, 2019
Merged

Added image sample and fixed a couple bugs #2649

3 commits merged into from
Jun 20, 2019

Conversation

@marlenecota
Copy link
Contributor

@marlenecota marlenecota commented Jun 19, 2019 •
edited by ghost
Loading

  • Added a sample that sets an Image's resizeMode from the selected Picker value
  • Fixed an issue where images weren't centered after switching back from 'repeat'
  • Fixed an issue where the image wasn't updating when switching the source.
Microsoft Reviewers: Open in CodeFlow

@marlenecota marlenecota requested a review from stecrain June 19, 2019 23:32
@marlenecota marlenecota requested a review from a team as a code owner June 19, 2019 23:32
@marlenecota marlenecota requested a review from ahimberg June 19, 2019 23:38
kmelmon
kmelmon approved these changes Jun 19, 2019
View reviewed changes
Copy link
Contributor

@kmelmon kmelmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@marlenecota marlenecota added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Jun 20, 2019
@ghost
Copy link

ghost commented Jun 20, 2019

Hello @marlenecota!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 096b738 into microsoft:master Jun 20, 2019
@marlenecota marlenecota deleted the image-sample branch September 8, 2020 21:54
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisglein chrisglein chrisglein approved these changes

@ahimberg ahimberg Awaiting requested review from ahimberg

+2 more reviewers

@kmelmon kmelmon kmelmon approved these changes

@stecrain stecrain stecrain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marlenecota @chrisglein @kmelmon @stecrain