Delay setting ReactImageBrush source until image has actually loaded #2654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stecrain
reviewed
Jun 20, 2019
marlenecota
reviewed
Jun 20, 2019
Contributor
marlenecota
reviewed
Jun 20, 2019
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stecrain
approved these changes
Jun 20, 2019
stecrain
approved these changes
Jun 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
m_brush->Source(surface);fromReactImage::Sourcesurfacein a lambda passed toLoadCompletedin order to keep it from being destructed until being assigned to the ReactImageBrushWhy
As it stands, switching the source of an Image between large images causes noticeable flashes while the image loads (gif at 2x slowdown to make it more obvious):
This is occurring because of the time it takes to load and decode these images. If the CompositionSurfaceBrush's surface is set to a LoadedImageSurface while it's still decoding, the surface is cleared. This change makes it so that the surface isn't set until the image is already decoded, so switching is smooth:
I'm inexperienced with both UWP and modern C++, so I'm very open to suggestions on a better way to do this.
Microsoft Reviewers: Open in CodeFlow