Fix Memory Leak in ViewViewManager #2658
Conversation
stecrain
requested review from
acoates-ms,
ahimberg,
akrantz,
jonthysell and
kmelmon
|
|
||
| winrt::com_ptr<ViewPanel> GetViewPanel() | ||
| winrt::com_ptr<ViewPanel> GetViewPanel(bool removeAllChildren = false) | ||
| { |
There was a problem hiding this comment.
This feels like an odd way to induce removal of the children. Why this instead of just embedding this in removeAllChildren()? Just the logic for getting the container? #Closed
There was a problem hiding this comment.
I didn't want to duplicate the logic to check for the control and the border.
But now that you mention it, including a param removeAllChildren on GetViewPanel does seem strange. I'll take another crack at this. #Closed
There was a problem hiding this comment.
It also might work to include more helper functions so you don't duplicate too much logic.
In reply to: 296325388 [](ancestors = 296325388)
ghost
added
the
Needs: Author Feedback
ghost
removed
the
Needs: Author Feedback
stecrain
added
the
AutoMerge
|
Hello @stecrain! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 2 participants
I found this with windbg and !idallocs provided by the UIExtensions.
Internal to Microsoft you should be able to open windbg, attach to a running React Native Windows App and use the command !idallocs, if it does not get the ui extensions automatically for you, then you probably need to update your debuggers.
Before this fix you could see the number of Windows_UI_Xaml!CPanel objects increasing as you visit more pages.
Using the !xamlTree debugger extensions you can see that some of the panels have no children, and their parent is a border. This made the leak pretty easy to pinpoint.
After this fix I am able to Go back and forth between pages (starting and ending on the same page), and see that the number of Windows_UI_Xaml!CPanel objects in the heap remains constant.
Microsoft Reviewers: Open in CodeFlow