-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Adding support for setting a custom root path for bundle loading #2690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akrantz
reviewed
Jun 27, 2019
akrantz
suggested changes
Jun 27, 2019
Contributor
akrantz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on my previous comment, let's normalize with other work done for Office to allow overriding parts of the source bundle url (host/port/path/extension). If only the path component should be able to be normalized now, it could still use the same naming.
marlenecota
reviewed
Jun 27, 2019
akrantz
reviewed
Jun 27, 2019
marlenecota
reviewed
Jun 27, 2019
marlenecota
approved these changes
Jun 28, 2019
akrantz
reviewed
Jun 28, 2019
akrantz
approved these changes
Jun 28, 2019
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ahimberg
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, RNW is configured to always load bundles using the "ms-appx:///Bundle/" URI and root path. There are some scenarios where this hardcoded value does not work; for example, when the bundle resides in an optional package, the URI needs to include the PFN.
This PR adds an option for developers to specify their own root path for bundle loading.
Microsoft Reviewers: Open in CodeFlow