Skip to content

Conversation

@sayzenberg
Copy link
Contributor

@sayzenberg sayzenberg commented Jun 27, 2019

Currently, RNW is configured to always load bundles using the "ms-appx:///Bundle/" URI and root path. There are some scenarios where this hardcoded value does not work; for example, when the bundle resides in an optional package, the URI needs to include the PFN.

This PR adds an option for developers to specify their own root path for bundle loading.

  • DevSettings and ReactInstanceSettings now contain new fields for specifying the use of a custom path and the custom path itself.
  • UwpReactInstance now contains a new helper to return the root path to classes that don't have references to DevSettings
  • OInstance and ReactImage both use the custom root path when available.
Microsoft Reviewers: Open in CodeFlow

@sayzenberg sayzenberg requested a review from a team as a code owner June 27, 2019 18:14
@ghost ghost added the vnext label Jun 27, 2019
Copy link
Contributor

@akrantz akrantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my previous comment, let's normalize with other work done for Office to allow overriding parts of the source bundle url (host/port/path/extension). If only the path component should be able to be normalized now, it could still use the same naming.

@ghost ghost added Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) and removed Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) labels Jun 27, 2019
@ahimberg
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ahimberg ahimberg merged commit aa95e0b into microsoft:master Jun 28, 2019
@sayzenberg sayzenberg deleted the altBundlePath branch June 28, 2019 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants