fix Animated shutdown crash #2707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
StephenLPeters
approved these changes
Jun 30, 2019
Contributor
StephenLPeters
left a comment
StephenLPeters
left a comment
There was a problem hiding this comment.
Looks like a good change to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If animation manager manually shuts down / drops animations before they complete, we currently crash in the Completed notification looking at freed memory. We have some things in a flyout animating that get manually shut down as the flyout closes that are crashing with animated now existing (I think before just some debug message was being shown about animated not being implemented)
This probably was working before we removed the shared_ptr types that would keep some stuff alive.
Fix - manually revoke (since the auto revoker was noted as not working)
Also fix make_unique code in animated to not do an extra copy. Discovered when I tested auto_revoker it wouldn't compile because there is no copyctor for auto_revoker.
Microsoft Reviewers: Open in CodeFlow