Use maxDesiredSize param with LoadedImageSurface #2863
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonthysell
reviewed
Aug 1, 2019
jonthysell
requested changes
Aug 1, 2019
Contributor
jonthysell
left a comment
jonthysell
left a comment
There was a problem hiding this comment.
Max size should be determined based on whatever stored values there are for width/height (not assuming source and width, height are set in the same batch), and unfortunately changes to that width/height properties might require reloading that image.
ghost
added
the
Needs: Author Feedback
kmelmon
reviewed
Aug 2, 2019
ghost
removed
the
Needs: Author Feedback
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of Image perf improvements (#2652) - if height or width has been set to a fixed size (no dynamic resizing needing), limit the image surface to that size.
Part 2 will cover using XamlBrush/BitmapImage when a CompositionBrush is not needed.
Microsoft Reviewers: Open in CodeFlow