Skip to content

fix build error #3422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
acoates-ms merged 3 commits into from
Oct 30, 2019
Merged

fix build error #3422

acoates-ms merged 3 commits into from
Oct 30, 2019

Conversation

@enm10k
Copy link
Contributor

@enm10k enm10k commented Oct 15, 2019 •
edited
Loading

I'm still getting the same build error reported on #2531.
As @aiya000 described on the issue, after changing the file encoding, build completed successfully.

Microsoft Reviewers: Open in CodeFlow

@enm10k enm10k requested a review from a team as a code owner October 15, 2019 14:26
@ghost ghost added the vnext label Oct 15, 2019
@kmelmon
Copy link
Contributor

kmelmon commented Oct 15, 2019

Thanks for submitting a fix! You'll need to include a change file, this why the CI loop is failing.
Please run yarn change from the root of your enlistment, follow the steps, then push this change up.

@enm10k
Copy link
Contributor Author

enm10k commented Oct 15, 2019

@kmelmon
I appreciate your explanation.
I added a change file.

@acoates-ms acoates-ms added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Oct 15, 2019
@ghost
Copy link

ghost commented Oct 15, 2019

Hello @acoates-ms!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@enm10k
Copy link
Contributor Author

enm10k commented Oct 18, 2019

@kmelmon
Unfortunately, some checks failed.
It looks similar to this issue #3444.
I would appreciate if you could advise me on how to handle the situation.

@enm10k enm10k requested a review from acoates-ms October 18, 2019 08:46
@licanhua
Copy link
Contributor

licanhua commented Oct 24, 2019

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 24, 2019

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost removed the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Oct 29, 2019
@enm10k
Copy link
Contributor Author

enm10k commented Oct 30, 2019

@licanhua
All checks have passed successfully now.
Could we get this merged?

@acoates-ms acoates-ms merged commit d958fd0 into microsoft:master Oct 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acoates-ms acoates-ms Awaiting requested review from acoates-ms

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@enm10k @kmelmon @licanhua @acoates-ms