Don't hardcode the path to v141 platform toolset #3434
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
chrisglein
reviewed
Oct 16, 2019
Contributor
|
(Bumping to main conversation for visibility). This will break |
Member
Author
agree but since Office requires v141 for now, we can address that, move to default (v142) and remove the forced target path altogether in the same change |
Contributor
JunielKatarn
left a comment
JunielKatarn
left a comment
There was a problem hiding this comment.
Please double-check whether to include the ARM VC tools.
added 16 commits
October 17, 2019 14:24
This was referenced Oct 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the hardcoded path to C:\Program Files (x86)\ ... where we go look for v141 tool. This addresses #3430 and #3435
Microsoft Reviewers: Open in CodeFlow