Fix run-windows app installation hang #3447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
An alternative would be to always allow output from the install command. -- Which might make sense. Its not a very noisy command output wise, compared to say build. And would allow the user to still have proper control over the prompt. Not sure what peoples thoughts on that are though. #Resolved |
Contributor
Author
|
I think it is still better to have spinner running by default for all steps, to be consistent. In reply to: 543260149 [](ancestors = 543260149) |
added 2 commits
October 17, 2019 10:00
asklar
reviewed
Oct 18, 2019
asklar
reviewed
Oct 18, 2019
| const installingText = 'Installing new version of the app'; | ||
| const installApp = `-ExecutionPolicy RemoteSigned Import-Module "${windowsStoreAppUtils}"; Install-App "${script}"`; | ||
| const installAppCmd = options.force ? installApp + ' -Force' : installApp; | ||
| const installApp = `-ExecutionPolicy RemoteSigned Import-Module "${windowsStoreAppUtils}"; Install-App "${script}" -Force`; |
Member
There was a problem hiding this comment.
installApp [](start = 8, length = 10)
add -NoProfile here too :) #Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3190
Microsoft Reviewers: Open in CodeFlow