Skip to content

Implement AccessibilityActions #3475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
licanhua merged 1 commit into from
Oct 29, 2019
Merged

Implement AccessibilityActions #3475

licanhua merged 1 commit into from
Oct 29, 2019

Conversation

@licanhua
Copy link
Contributor

@licanhua licanhua commented Oct 21, 2019 •
edited by ghost
Loading

fix #2765

add new AccessibilityActions: invoke, addToSelection, removeFromSelection, select, toggle, expand and collapse.

The following tasks are not in the scope of this PR, but they are related.

  1. I did the test manually. Expect automation when Create native module to support Accessiblity testing. #3473 is delivered.
  2. The typescript for AccessiblityAction is not ready yet, and expect it be delivered in Make typescript of react-native to support accessibilityActions like invoke, addToSelection, removeFromSelection, select, toggle, expand and collapse #3474
  3. I applied a workaround in ABI/idl/AccessibilityAction, and it should be removed when implementing Support 2.0 CppWinRT #2455
Microsoft Reviewers: Open in CodeFlow

@licanhua licanhua requested a review from a team as a code owner October 21, 2019 23:34
@licanhua licanhua requested a review from jonthysell October 21, 2019 23:34
@licanhua
Copy link
Contributor Author

licanhua commented Oct 22, 2019

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 22, 2019

Pull request contains merge conflicts.

@licanhua
Copy link
Contributor Author

licanhua commented Oct 22, 2019

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 22, 2019

Azure Pipelines successfully started running 1 pipeline(s).

asklar
asklar reviewed Oct 23, 2019
View reviewed changes
stecrain
stecrain reviewed Oct 28, 2019
View reviewed changes
@licanhua licanhua merged commit 97955e9 into microsoft:master Oct 29, 2019
@licanhua licanhua deleted the action2 branch October 29, 2019 23:33
@chrisglein chrisglein mentioned this pull request Nov 21, 2023
Closed
@chiaramooney chiaramooney mentioned this pull request Jun 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonthysell jonthysell Awaiting requested review from jonthysell

2 more reviewers

@asklar asklar asklar left review comments

@stecrain stecrain stecrain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement accessibilityActions

3 participants

@licanhua @asklar @stecrain