Removed MainReactNativeHost from samples and use ReactApplication properties instead #3501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmoroz
requested review from
a team,
NikoAri,
acoates-ms,
jonthysell and
stmoy
acoates-ms
approved these changes
Oct 23, 2019
asklar
reviewed
Oct 23, 2019
| ReactApplicationDelegate __stdcall CreateReactApplicationDelegate() { | ||
| return winrt::Microsoft::ReactNative::ReactApplicationDelegate(*this); | ||
| } | ||
| virtual ReactApplicationDelegate __stdcall CreateReactApplicationDelegate(); |
Member
There was a problem hiding this comment.
__stdcall [](start = 35, length = 9)
why is this necessary?
Member
Author
There was a problem hiding this comment.
I am not sure. It was there before. I would like to remove the ReactApplicationDelegate in future iterations. IMHO, there are too many types in the API that we must remove.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requiring the MainReactNativeHost component in each sample project that we plan to generate by CLI seems to be an unnecessary overhead. All application-wide properties can be set directly on the ReactApplication component.
In this change:
Note, that the new ReactApplication properties are the same as they used to be in MainReactNativeHost. We just let them to be set in constructor instead of overriding. In one of the next changes we might change the property names and how they are grouped.
Microsoft Reviewers: Open in CodeFlow