Skip to content

Conversation

@licanhua
Copy link
Contributor

@licanhua licanhua commented Oct 28, 2019

Test is disable when investigating #3444, re-enable it.

Microsoft Reviewers: Open in CodeFlow

@licanhua licanhua requested a review from a team as a code owner October 28, 2019 18:26
@ghost ghost added the vnext label Oct 28, 2019
@JunielKatarn
Copy link
Contributor

What was the issue with this test to begin with?
In my local dev test runs, it had never failed before.

@JunielKatarn
Copy link
Contributor

For future test enabling/disabling, please modify the build variable Desktop.IntegrationTests.Filter instead (see windows-vs-pr.yml):

(FullyQualifiedName!~WebSocketJSExecutorIntegrationTest)&(FullyQualifiedName!~<whichever test you want to disable>)

This is especially important if tests are only failing in the PR loops, but not in local dev machines (which has been the case for most of the Desktop integration tests).

@licanhua licanhua merged commit 1a82a2c into microsoft:master Oct 30, 2019
@licanhua licanhua deleted the EnableIntegrationTestHarness branch October 30, 2019 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants