Add todo stub for FacadeType::Progress in AnimatedNode #3544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
namrog84
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3283
This doesn't fix the deeper underlying issue, but we are hitting the assert because of a missing type. And a registered empty noop stub is adequate to address this issue for us.
We are in the progress of implementing a custom LottieView that uses AnimatedVisualPlayer and somewhere in the https://github.com/react-native-community/lottie-react-native they are touching the 'progress'. We don't think we actually need/use it anywhere, but the assert is causing problems.
Microsoft Reviewers: Open in CodeFlow