Skip to content

Set a default 3D perspective #3551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
asklar merged 4 commits into from
Oct 30, 2019
Merged

Set a default 3D perspective #3551

asklar merged 4 commits into from
Oct 30, 2019

Conversation

@asklar
Copy link
Member

@asklar asklar commented Oct 29, 2019 •
edited
Loading

We need to set a perspective to match React Native's perspective, otherwise we get an orthographic projection

Fixes #3093

Microsoft Reviewers: Open in CodeFlow

@asklar asklar requested a review from a team as a code owner October 29, 2019 00:50
@ghost ghost added the vnext label Oct 29, 2019
@asklar asklar requested a review from StephenLPeters October 29, 2019 15:28
StephenLPeters
StephenLPeters reviewed Oct 29, 2019
View reviewed changes
StephenLPeters
StephenLPeters reviewed Oct 29, 2019
View reviewed changes
StephenLPeters
StephenLPeters reviewed Oct 29, 2019
View reviewed changes
StephenLPeters
StephenLPeters suggested changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@StephenLPeters StephenLPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

@ghost ghost added Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) and removed Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) labels Oct 29, 2019
@asklar asklar requested a review from StephenLPeters October 29, 2019 23:58
@asklar asklar mentioned this pull request Oct 30, 2019
Closed
StephenLPeters
StephenLPeters approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@StephenLPeters StephenLPeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@asklar
Copy link
Member Author

asklar commented Oct 30, 2019

I checked with George and comp folks that DWM will be smart enough to optimize out any scenes where we have a perspective but no elements outside z=0 (i.e. no 3D rotations)

@asklar asklar merged commit e10725d into master Oct 30, 2019
@acoates-ms acoates-ms deleted the user/asklar/perspective branch December 6, 2019 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@acoates-ms acoates-ms acoates-ms left review comments

+1 more reviewer

@StephenLPeters StephenLPeters StephenLPeters approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix default perspective for 3D transforms

4 participants

@asklar @StephenLPeters @acoates-ms