Skip to content

Conversation

@ddalp
Copy link
Contributor

@ddalp ddalp commented Nov 1, 2019

#3065 #3066
Add support for snapToStart and snapToEnd when snapOffsets is set. This is done by inserting additional snap points for start and end points. There are several factors to consider when calculating these two points, they are not just simply the offset 0 and extent width, two main factors to consider: -when current viewport is scaled;
-snap alignment (near, far and center).

While testing the snapToStart and snapToEnd, I also fixed few other scrollView issues:

  • ScrollViewer's scaling is not working, we should set ZoomMode to enabled if minimumZoomScale is different from maximumZoomScale, to enable scaling.
  • If zoomScale property is set earlier before ScrollViewer is loaded, it will be omitted. We should defer calling ChangView in that situation.
    Also adding a playground sample script to be test snap points combination scenarios.
Microsoft Reviewers: Open in CodeFlow

@ddalp ddalp requested a review from a team as a code owner November 1, 2019 16:20
@ddalp ddalp requested a review from chrisglein November 1, 2019 16:20
Copy link
Contributor

@kmelmon kmelmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ddalp ddalp merged commit 1f1cc0b into microsoft:master Nov 1, 2019
@ddalp ddalp deleted the scrollviewer branch November 1, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants