Move ScriptStore and RuntimeHolder from RN to RNW. #3577
Conversation
ghost
added
the
| #include <jsi/jsi.h> | ||
| #include <memory> | ||
|
|
||
| namespace facebook { |
There was a problem hiding this comment.
{ [](start = 19, length = 1)
(nit) why not use latest faceboo::jsi syntax for namespaces?
| namespace facebook { | ||
| namespace jsi { | ||
|
|
||
| // An instance of this interface is expected to |
There was a problem hiding this comment.
// [](start = 0, length = 2)
(nit) We should have proper documetation standard at least for new code, eg, doxygen. So comments would be:
//!
| // a. lazily create a JSI Runtime on the first call to getRuntime | ||
| // b. subsequent calls to getRuntime should return the Runtime created in (a) | ||
|
|
||
| // Note :: All calls to getRuntime() should happen on the same thread unless you are sure that |
There was a problem hiding this comment.
the same thread [](start = 54, length = 15)
(nit) do we care to have code that asserts this?
| // JSI::Runtime implementation must be provided an instance on this interface to enable version sensitive capabilities | ||
| // such as usage of pre-prepared javascript script. Alternatively, this entity can be used to directly provide the | ||
| // Javascript buffer and rich metadata to the JSI::Runtime instance. | ||
| struct ScriptStore { |
There was a problem hiding this comment.
ScriptStore [](start = 7, length = 11)
Aren't we planning to get rid of this per discussion last week?
There was a problem hiding this comment.
Yes. This PR is just moving RuntimeHolde.h and ScriptStore.h from RN to RNW and I am planning on making more changes here. I'll also fix the nit comments then.
In reply to: 341760394 [](ancestors = 341760394)
| #include <jsi/RuntimeHolder.h> | ||
| #include <jsi/ScriptStore.h> | ||
| #include <JSI/Shared/RuntimeHolder.h> | ||
| #include <jsi/Shared/ScriptStore.h> |
There was a problem hiding this comment.
jsi/ [](start = 10, length = 4)
(nit) please be consistent in casing
4 participants
This PR moves ScriptStore and RuntimeHolder from RN to RNW. See also microsoft/react-native-macos#185.
Microsoft Reviewers: Open in CodeFlow