Add DebugBundle/ReleaseBundle configs to sample cpp app #3588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmoroz
reviewed
Nov 5, 2019
| JavaScriptBundleFile(L"index.windows"); | ||
| InstanceSettings().UseWebDebugger(false); | ||
| InstanceSettings().UseLiveReload(false); | ||
| #endif |
Member
There was a problem hiding this comment.
These are default settings. I also find that this unnecessary makes the user code more complex. Can we avoid adding this code?
Member
There was a problem hiding this comment.
Thinking about this change: it seems that it is a quite complex approach to create a new build configuration every time when we want to customize run of RN app. A better approach is when the ReactApplication can read parameters from a command line or from some other config file. That way we can provide customization as a part of CLI and/or debug parameters in VS. It would give us more flexibility and be aligned with RN on other platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready for review yet.
Microsoft Reviewers: Open in CodeFlow