Skip to content

Workaround for flyout centering problem #3640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
3 commits merged into from Nov 11, 2019
Merged

Workaround for flyout centering problem #3640

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7c15f83
Workaround for flyout centering problem
Nov 11, 2019
b0defe8
adding comment explaining fix
Nov 11, 2019
23ac05f
Change files
Nov 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions change/react-native-windows-2019-11-11-12-58-16-flyout-centering-workaround.2.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "prerelease",
"comment": "Workaround for flyout centering problem",
"packageName": "react-native-windows",
"email": "kenander@microsoft.com",
"commit": "b0defe86c05d88310fb66663be45dd925d3b3207",
"date": "2019-11-11T20:58:16.583Z"
}
11 changes: 11 additions & 0 deletions vnext/ReactUWP/Views/FlyoutViewManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,17 @@ void FlyoutShadowNode::AddView(ShadowNode &child, int64_t index) {

if (m_flyout != nullptr) {
m_flyout.Content(childView.as<winrt::UIElement>());
if (winrt::FlyoutPlacementMode::Full == m_flyout.Placement()) {
// When using FlyoutPlacementMode::Full on a Flyout with an embedded
// Picker, the flyout is not centered correctly. Below is a temporary
// workaround that resolves the problem for flyouts with fixed size
// content by adjusting the flyout presenter max size settings prior to
// layout. This will unblock those scenarios while the work on a more
// exhaustive fix proceeds. Tracked by Issue #2969
if (auto fe = m_flyout.Content().try_as<winrt::FrameworkElement>()) {
AdjustDefaultFlyoutStyle((float)fe.Width(), (float)fe.Height());
Copy link
Contributor

@kmelmon kmelmon Nov 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AdjustDefaultFlyoutStyle((float)fe.Width(), (float)fe.Height()) [](start = 8, length = 63)

Please add a comment saying this is a temporary workaround and why it's needed.

Copy link
Author

@ghost ghost Nov 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do.

}
}
}
}

Expand Down