Skip to content

Conversation

@licanhua
Copy link
Contributor

@licanhua licanhua commented Nov 13, 2019

Fix #3657 to remove DebugBundle and ReleaseBundle.

In this PR, I only made change to \microsoft-reactnative-sampleapps and ReactUWPTestApp and template projects which includes the examples for both C++ and C# application which will unblocked me from the WinUI integration.

Customer can overwrite below properties in the project file
UseBundle - By default, UseBundle is enabled in release configuration and disabled in debug configuration.
BundledContent - By default, bundled files are expected to put in Bundle. and project will package all files in Bundle\**\* if UseBundle is true.
BundleCommand - Expect it to be defined in the app.

I don't know if Exec target is valid on Linux and iOS. If not, BundleCommand doesn't work too even if you set it.

Because the bundle command is high customized, I didn't provide default command for it. and you have to provide BundleCommand in your project if you want to make bundle automatically.

as a user, customer only need to import Bundle.targets which will import the Bundle.property automatically.

  <PropertyGroup>
    <BundleCommand>
      cd $(SolutionDir)..
      mkdir windows\SampleAppCpp\Bundle
      react-native bundle --platform windows --entry-file index.windows.js --bundle-output windows/SampleAppCpp/Bundle/index.windows.bundle --assets-dest windows/SampleAppCpp/Bundle
    </BundleCommand>
  </PropertyGroup>
  <Import Project="$(ReactNativeWindowsDir)\PropertySheets\Bundle.targets" />

For Cpp project,

 <Import Project="$(ReactNativeWindowsDir)\PropertySheets\Bundle.Cpp.targets" />
Microsoft Reviewers: Open in CodeFlow

@ghost ghost added the vnext label Nov 13, 2019
@ghost ghost added the Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) label Nov 13, 2019
@ghost ghost removed the Needs: Author Feedback The issue/PR needs activity from its author (label drives bot activity) label Nov 13, 2019
@licanhua
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@licanhua licanhua changed the title Remove DebugBundle and ReleaseBundle configuration Remove DebugBundle and ReleaseBundle configuration - Part 1 Nov 19, 2019
@licanhua licanhua marked this pull request as ready for review November 19, 2019 01:11
@licanhua licanhua requested a review from a team as a code owner November 19, 2019 01:11
@kmelmon
Copy link
Contributor

kmelmon commented Nov 20, 2019

I don't see any changes to the solution/project files for the template apps generated by the CLI (see vnext\local-cli\generator-windows\templates). Were you planning on making those changes as part of this checkin? #Closed

@licanhua
Copy link
Contributor Author

licanhua commented Nov 21, 2019

I don't see any changes to the solution/project files for the template apps generated by the CLI (see vnext\local-cli\generator-windows\templates). Were you planning on making those changes as part of this checkin?

I already merged it into this PR #Closed

@licanhua licanhua changed the title Remove DebugBundle and ReleaseBundle configuration - Part 1 Remove DebugBundle and ReleaseBundle configuration Nov 21, 2019
@licanhua licanhua requested a review from kmelmon November 22, 2019 00:29
@kmelmon
Copy link
Contributor

kmelmon commented Nov 22, 2019

looks good thanks!


In reply to: 556911861 [](ancestors = 556911861)

Copy link
Contributor

@kmelmon kmelmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@licanhua licanhua merged commit d620648 into microsoft:master Nov 22, 2019
@licanhua licanhua deleted the removeBundle branch November 22, 2019 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove DebugBundle and ReleaseBundle configuration

4 participants