-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove DebugBundle and ReleaseBundle configuration #3654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
packages/E2ETest/windows/ReactUWPTestApp/ReactUWPTestApp.csproj
Outdated
Show resolved
Hide resolved
|
I don't see any changes to the solution/project files for the template apps generated by the CLI (see vnext\local-cli\generator-windows\templates). Were you planning on making those changes as part of this checkin? #Closed |
I already merged it into this PR #Closed |
|
looks good thanks! In reply to: 556911861 [](ancestors = 556911861) |
kmelmon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
Fix #3657 to remove DebugBundle and ReleaseBundle.
In this PR, I only made change to \microsoft-reactnative-sampleapps and ReactUWPTestApp and template projects which includes the examples for both C++ and C# application which will unblocked me from the WinUI integration.
Customer can overwrite below properties in the project file
UseBundle - By default, UseBundle is enabled in release configuration and disabled in debug configuration.
BundledContent - By default, bundled files are expected to put in Bundle. and project will package all files in
Bundle\**\*if UseBundle is true.BundleCommand - Expect it to be defined in the app.
I don't know if Exec target is valid on Linux and iOS. If not, BundleCommand doesn't work too even if you set it.
Because the bundle command is high customized, I didn't provide default command for it. and you have to provide BundleCommand in your project if you want to make bundle automatically.
as a user, customer only need to import Bundle.targets which will import the Bundle.property automatically.
For Cpp project,
Microsoft Reviewers: Open in CodeFlow