Skip to content

Conversation

@licanhua
Copy link
Contributor

@licanhua licanhua commented Nov 22, 2019

Reverts #3665
It crashed in latest inside build and have problem to GetForUIContext

  if (Is19H1OrHigher()) {
    // 19H1 and higher supports island scenarios
    auto uiElement(xamlView.as<winrt::UIElement>());
    m_coreInputView = winrt::CoreInputView::GetForUIContext(uiElement.UIContext());
  } else {
    m_coreInputView = winrt::CoreInputView::GetForCurrentView();
  }
Microsoft Reviewers: Open in CodeFlow

@licanhua licanhua requested a review from a team as a code owner November 22, 2019 19:03
@ghost ghost added the vnext label Nov 22, 2019
@licanhua licanhua requested a review from ddalp November 22, 2019 19:03
@licanhua licanhua added the AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity) label Nov 22, 2019
@ghost
Copy link

ghost commented Nov 22, 2019

Hello @licanhua!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link
Contributor

@ddalp ddalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ghost ghost merged commit 55ef15e into master Nov 22, 2019
@ghost ghost deleted the revert-3665-keyboardDismissMode branch November 22, 2019 20:05
ddalp pushed a commit to ddalp/react-native-windows that referenced this pull request Nov 22, 2019
ghost pushed a commit that referenced this pull request Nov 25, 2019
* Revert "Revert "Support ScrollView keyboardDismissMode" (#3692)"

This reverts commit 55ef15e.

* Properly support ScrollView KeyboardDismissMode

* Change files

* buildci

* Merge update
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AutoMerge Causes a PR to be automatically merged once all requirements are passed (label drives bot activity)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants