Logging and Tracing OSS_RN Removal #3934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Update NativeToJSBridge.h with a fix that was incorporated into Facebook master instead of our current fix. 2. Remove "ENABLE_NATIVE_SYSTRACE_TO_ETW". We don't check it in RNW or micosoft/react-native. 3. Remove conditional definition of ENABLE_ETW_TRACING for non-OSS React Native. We can build it just fine, since the patch we had was to fix an error exposed when "WITH_FBSYSTRACE" is defined. 4. Enable ENABLE_JS_SYSTRACE_TO_ETW in patched OSS RN 5. Consolidate preprocessor definitions tp React.cpp.props. WITH_FBSYSTRACE is checked in Facebook headers, meaning projects including Facebook headers that didn't copy the definitions may get mismatched headers. We should expose the definition to more projects to prevent this. 6. Remove conditional compilation of logMarker, since it builds in unpatched OSS RN and there are not any apparent divergences that would impact runtime behavior. Validated we build: - Universal Solution with OSS_RN, with and without patches - Desktop Solution with OSS_RN with patches, and not more broken without
ghost
added
the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Facebook master instead of our current fix.
ENABLE_NATIVE_SYSTRACE_TO_ETW. We don't check it in RNW ormicosoft/react-native.
ENABLE_ETW_TRACING for non-OSS ReactNative. We can build it just fine, since the patch we had was to fix an
error exposed when
WITH_FBSYSTRACEis defined.ENABLE_JS_SYSTRACE_TO_ETWin patched OSS RNWITH_FBSYSTRACEis checked in Facebook headers, meaning projectsincluding Facebook headers that didn't copy the definitions may get
mismatched headers. We should expose the definition to more projects to
prevent this.
unpatched OSS RN and there are not any apparent divergences that would
impact runtime behavior.
Validated we build:
OSS_RN, with and without patchesOSS_RNwith patches, and not more broken withoutMicrosoft Reviewers: Open in CodeFlow