Enable screen reader announcements for accessibilityLiveRegion #4043
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
|
acoates-ms
approved these changes
Feb 7, 2020
acoates-ms
added
the
AutoMerge
|
Hello @acoates-ms! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
This was referenced Feb 19, 2020
kmelmon
pushed a commit
that referenced
this pull request
Feb 20, 2020
#4139) * Add accessibilityLiveRegion to GetNativeProps * Change files * Formatting
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #3783.
Enables screen reader announcements when using an accessibilityLiveRegion. FrameworkElementViewManager already has code for handling an accessibilityLiveRegion announcement, but is currently filtering it out due to GetNativeProps not having an entry for it. This change adds that to the list of native props so that the existing code that responds when the accessibilityLiveRegion changes actually executes.
The existing code in question is in the same file under this if statement:
else if (propertyName == "accessibilityLiveRegion")Microsoft Reviewers: Open in CodeFlow