Fix for NormalizePath resolving IntDir based on current working directory #4108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
…the culprits here -- they normalize to an absolute path based on current working directory.
aschultz
changed the title
NickGerleman
approved these changes
Feb 15, 2020
Contributor
Author
|
@NickGerleman Mind merging this for me? |
kmelmon
pushed a commit
that referenced
this pull request
Feb 21, 2020
…tory (#4108) (#4161) * Fix issues with relative IntDir breaking builds * formatting * Change files * Re-order path resolution calls. NormalizePath/NormalizeDirectory are the culprits here -- they normalize to an absolute path based on current working directory. Co-authored-by: Aaron Schultz <codedclarity@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow