Fix concurrency issue in NetworkingModule #4179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
|
Member
Contributor
Author
Member
|
It seems that your PR is missing a change file. Please run 'yarn change' to create it. #Resolved |
vmoroz
reviewed
Feb 26, 2020
| winrt::Windows::Web::Http::HttpResponseMessage, | ||
| winrt::Windows::Web::Http::HttpProgress> httpRequest(nullptr); | ||
| { | ||
| std::scoped_lock(m_mutex); |
Member
There was a problem hiding this comment.
( [](start = 20, length = 1)
There must be a variable name for the lock.
Contributor
Author
There was a problem hiding this comment.
lamxdoan
added a commit
to lamxdoan/react-native-windows
that referenced
this pull request
Feb 26, 2020
* Add locking around access to m_requests * Change files * add locking around AbortRequest as well * fix formatting * lock needs local variable
ghost
pushed a commit
that referenced
this pull request
Feb 26, 2020
* Fix concurrency issue in NetworkingModule (#4179) * Add locking around access to m_requests * Change files * add locking around AbortRequest as well * fix formatting * lock needs local variable * Remove useIncrementalUpdates assert from Networking module (#4116) * Remove useIncrementalUpdates assert from Networking module * Change files * add [[maybe_unused]] Co-authored-by: Marlene Cota <marlenecota@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4174
Microsoft Reviewers: Open in CodeFlow