Skip to content

Conversation

@lamxdoan
Copy link
Contributor

@lamxdoan lamxdoan commented Mar 4, 2020

Cleaning up so ReactUWP\Utils header files are under the include directory. This allows consumers to use those utilities from within their app.

Microsoft Reviewers: Open in CodeFlow

@lamxdoan lamxdoan requested a review from a team as a code owner March 4, 2020 05:56
@ghost ghost added the vnext label Mar 4, 2020
@lamxdoan
Copy link
Contributor Author

lamxdoan commented Mar 4, 2020

@kmelmon @jagorrin

@NickGerleman
Copy link
Contributor

Out of curiosity, what specifically are you needing to use within your app? ReactUwp is on the deprecation path, so we need to be intentional about adding anything to its API surface. I.e. anything we add here might need to be mirrored in the new Microsoft.ReactNative APIs depending on what we're choosing to expose.

Copy link
Contributor

@kmelmon kmelmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@kmelmon kmelmon merged commit c67be51 into microsoft:master Mar 4, 2020
@lamxdoan
Copy link
Contributor Author

lamxdoan commented Mar 4, 2020

Out of curiosity, what specifically are you needing to use within your app? ReactUwp is on the deprecation path, so we need to be intentional about adding anything to its API surface. I.e. anything we add here might need to be mirrored in the new Microsoft.ReactNative APIs depending on what we're choosing to expose.

We're building a new ViewManager that wraps AutoSuggestBox and need some of the useful functions from PropertyUtils.h (TryUpdateFontProperties, TryUpdateCharacterSpacing, etc)

lamxdoan added a commit to lamxdoan/react-native-windows that referenced this pull request Mar 4, 2020
…rosoft#4230)

* Moved header files from ReactUWP\Utils to include\ReactUWP\Utils. Updated project references.

* updated includes to use <Utils/*>

* checkin auto fix include order

* Change files
NickGerleman added a commit that referenced this pull request Mar 4, 2020
…ctUWP\\Utils. Updated project references. (#4233)

* Moved header files from ReactUWP\Utils to include\ReactUWP\Utils (#4230)

* Moved header files from ReactUWP\Utils to include\ReactUWP\Utils. Updated project references.

* updated includes to use <Utils/*>

* checkin auto fix include order

* Change files

* reapply changes to ReactUWP.vcxproj
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants