Skip to content

Move ViewPanel import from PropertyUtils to FrameworkElementViewManager #4236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmelmon merged 1 commit into from
Mar 5, 2020
Merged

Move ViewPanel import from PropertyUtils to FrameworkElementViewManager #4236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions change/react-native-windows-2020-03-04-16-35-45-ViewPanelImportFix.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "prerelease",
"comment": "Move ViewPanel import from PropertyUtils to FrameworkElementViewManager",
"packageName": "react-native-windows",
"email": "jagorrin@microsoft.com",
"commit": "9dfc7b5bce7de1508eb2dc31fbdf597929f839f3",
"dependentChangeType": "patch",
"date": "2020-03-05T00:35:45.422Z"
}
2 changes: 2 additions & 0 deletions vnext/ReactUWP/Views/FrameworkElementViewManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@

#include "DynamicAutomationProperties.h"

#include <Views/ViewPanel.h>

namespace winrt {
using namespace Windows::UI::Xaml;
using namespace Windows::UI::Xaml::Controls;
Expand Down
2 changes: 0 additions & 2 deletions vnext/include/ReactUWP/Utils/PropertyUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@

#include <Views/ShadowNodeBase.h>

#include <Views/ViewPanel.h>

namespace winrt {
using namespace Windows::UI::Xaml;
}
Expand Down