Enable V8 JSI support for win32 #4241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 5, 2020 09:44
ghost
added
the
NickGerleman
reviewed
Mar 5, 2020
| VerticalAlignment="Center" | ||
| IsChecked="true" | ||
| Content="Reuse Instance"/> | ||
| <TextBlock |
Contributor
There was a problem hiding this comment.
Could we make the playground changes in a separate change in master instead of bundling them with the backport?
Member
Author
There was a problem hiding this comment.
I will submit a separate PR for master, the Playground project changed somewhat so it won't be a straight cherry-pick.
Contributor
There was a problem hiding this comment.
That seems reasonable for this change, since it's pretty trivial/low-risk. In general though there's some nicety of being able to map commits 1:1 between branches . IIRC we've also made changes before in stable branches which we forgot to bring to master.
NickGerleman
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports the same change from master; it enables V8 as an optional JSI engine implementation.
Microsoft Reviewers: Open in CodeFlow