[Do not check in] Working Branch for 0.62 Upgrade #4300
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that we don't have typings for 0.62 yet, so we explicitly allow typings for 0.61 until it's out.
Punting on anything where more focus is needed for now. Looks like we will also need to move color related overrides to StyleSheet
Fix a bad merge of RCTNetworking and revert some updated typings that seem to break NativeEventEmitter.
We also need to move RNTester Windows to relative paths since we end up changing ordering and not generating the index.js by the time we try to import the react-native-windows package.
This is a near copy from the Android Flow versions, but outdated and with slightly less accurate typings. Move to Flow so we can get type-checking and auto-updates going forward.
…and seems unrelated.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow