Skip to content

Set TabIndex to 0 for ScrollViewers #4328 #4332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kmelmon merged 2 commits into from
Mar 17, 2020
Merged

Set TabIndex to 0 for ScrollViewers #4328 #4332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27ddfb0
Change files
jagorrin Mar 16, 2020
b044f8f
Merge branch '0.60-stable' into ScrollViewFix0_60
jagorrin Mar 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions change/react-native-windows-2020-03-16-16-20-55-ScrollViewFix.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{
"type": "prerelease",
"comment": "Set TabIndex to 0 for ScrollViewers",
"packageName": "react-native-windows",
"email": "jagorrin@microsoft.com",
"commit": "43332258ca84856eff48e593e140e1ab91d7f7fa",
"dependentChangeType": "patch",
"date": "2020-03-16T23:20:55.206Z"
}
1 change: 1 addition & 0 deletions vnext/ReactUWP/Views/ScrollViewManager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ void ScrollViewShadowNode::createView() {
Super::createView();

const auto scrollViewer = GetView().as<winrt::ScrollViewer>();
scrollViewer.TabIndex(0);
const auto scrollViewUWPImplementation = ScrollViewUWPImplementation(scrollViewer);
scrollViewUWPImplementation.ScrollViewerSnapPointManager();

Expand Down