Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .ado/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ jobs:
- template: templates/build-rnw.yml
parameters:
project: vnext/ReactWindows-Universal.sln
msBuildArchitecture: x86 # Necessary to build C# unit tests
vsComponents: $(VsComponents),Microsoft.VisualStudio.Component.VC.v141.ARM,Microsoft.VisualStudio.Component.VC.v141.ARM64

- template: templates/publish-build-artifacts-for-nuget.yml
Expand Down
11 changes: 7 additions & 4 deletions .ado/templates/build-rnw.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,17 +34,20 @@ steps:
restoreDirectory: packages/
verbosityRestore: Detailed # Options: quiet, normal, detailed

- task: MSBuild@1
displayName: MSBuild ${{parameters.project}}
- task: VSBuild@1
displayName: VSBuild ${{parameters.project}}
inputs:
solution: ${{parameters.project }}
msbuildVersion: ${{parameters.msbuildVersion}}
vsVersion: ${{parameters.msbuildVersion}}
msbuildArchitecture: ${{parameters.msBuildArchitecture}}
platform: $(BuildPlatform)
configuration: $(BuildConfiguration)
clean: false # Optional
maximumCpuCount: false # Optional
restoreNugetPackages: false # Optional
createLogFile: true
logFileVerbosity: detailed
msbuildArguments:
msbuildArgs:
/p:PreferredToolArchitecture=${{parameters.preferredToolArchitecture}}
/p:PlatformToolset=${{parameters.platformToolset}}
/p:BaseIntDir=$(BaseIntDir)
Expand Down
14 changes: 9 additions & 5 deletions .ado/templates/react-native-init.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,20 +87,24 @@ steps:
-Components ${{ parameters.vsComponents }}
condition: and(ne('${{parameters.vsComponents}}', ''), eq(variables['VmImage'], 'windows-2019'))

- task: MSBuild@1
displayName: MSBuild - testcli
- task: VSBuild@1
displayName: VSBuild - testcli
inputs:
solution: $(Agent.BuildDirectory)\testcli\windows\testcli.sln
msbuildVersion: $(MSBuildVersion) # Optional. Options: latest, 16.0, 15.0, 14.0, 12.0, 4.0
msbuildArchitecture: x86 # $(MSBuildArchitecture) # Optional. Options: x86, x64
vsVersion: $(MSBuildVersion) # Optional. Options: latest, 16.0, 15.0, 14.0, 12.0, 4.0
msbuildArchitecture: $(MSBuildArchitecture) # Optional. Options: x86, x64
platform: ${{ parameters.platform }} # Optional
configuration: ${{ parameters.configuration }} # Optional
clean: false # Optional
maximumCpuCount: false # Optional
restoreNugetPackages: false # Optional
createLogFile: true
logFileVerbosity: detailed
msbuildArguments:
msbuildArgs:
/p:PreferredToolArchitecture=$(MSBuildPreferredToolArchitecture)
/p:PlatformToolset=$(MSBuildPlatformToolset)
/p:BaseIntDir=$(BaseIntDir)
/p:AppxGeneratePrisForPortableLibrariesEnabled=false

- task: PublishBuildArtifacts@1
condition: succeededOrFailed()
Expand Down
25 changes: 14 additions & 11 deletions .ado/windows-vs-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ jobs:
parameters:
yarnBuildCmd: build
project: vnext/ReactWindows-Universal.sln
msBuildArchitecture: x86 # Necessary to build C# unit tests
vsComponents: $(VsComponents),Microsoft.VisualStudio.Component.VC.v141.ARM,Microsoft.VisualStudio.Component.VC.v141.ARM64

- task: VSTest@2
Expand Down Expand Up @@ -134,19 +133,21 @@ jobs:
restoreSolution: packages/playground/windows/Playground.sln
verbosityRestore: Detailed # Options: quiet, normal, detailed

- task: MSBuild@1
displayName: MSBuild - Playground
- task: VSBuild@1
displayName: VSBuild - Playground
inputs:
solution: packages/playground/windows/Playground.sln
msbuildVersion: $(MSBuildVersion) # Optional. Options: latest, 16.0, 15.0, 14.0, 12.0, 4.0
vsVersion: $(MSBuildVersion) # Optional. Options: latest, 16.0, 15.0, 14.0, 12.0, 4.0
msbuildArchitecture: $(MSBuildArchitecture) # Optional. Options: x86, x64
platform: $(BuildPlatform) # Optional
configuration: $(BuildConfiguration) # Optional
msbuildArguments:
clean: true # Optional
maximumCpuCount: false # Optional
restoreNugetPackages: false # Optional
msbuildArgs:
/p:PreferredToolArchitecture=$(MSBuildPreferredToolArchitecture)
/p:PlatformToolset=$(MSBuildPlatformToolset)
/p:BaseIntDir=$(BaseIntDir)
clean: true # Optional

- task: NuGetCommand@2
displayName: NuGet restore - Playground Win32
Expand All @@ -155,19 +156,21 @@ jobs:
restoreSolution: packages/playground/windows/Playground-Win32.sln
verbosityRestore: Detailed # Options: quiet, normal, detailed

- task: MSBuild@1
displayName: MSBuild - Playground Win32
- task: VSBuild@1
displayName: VSBuild - Playground Win32
inputs:
solution: packages/playground/windows/Playground-Win32.sln
msbuildVersion: $(MSBuildVersion) # Optional. Options: latest, 16.0, 15.0, 14.0, 12.0, 4.0
vsVersion: $(MSBuildVersion) # Optional. Options: latest, 16.0, 15.0, 14.0, 12.0, 4.0
msbuildArchitecture: $(MSBuildArchitecture) # Optional. Options: x86, x64
platform: $(BuildPlatform) # Optional
configuration: $(BuildConfiguration) # Optional
msbuildArguments:
clean: true # Optional
maximumCpuCount: false # Optional
restoreNugetPackages: false # Optional
msbuildArgs:
/p:PreferredToolArchitecture=$(MSBuildPreferredToolArchitecture)
/p:PlatformToolset=$(MSBuildPlatformToolset)
/p:BaseIntDir=$(BaseIntDir)
clean: true # Optional

- task: CmdLine@2
displayName: Create Playground bundle
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
{
"type": "prerelease",
"comment": "Update MSBuild Tasks to use MSBuild x64",
"packageName": "react-native-windows",
"email": "jthysell@microsoft.com",
"dependentChangeType": "patch",
"date": "2020-03-31T17:16:02.126Z"
}
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
<PackageCertificateThumbprint>FCDD40CD2A4E90DD1F10E5C04D5A958E6B5311CA</PackageCertificateThumbprint>
<PackageCertificateKeyFile>ReactUWPTestApp_TemporaryKey.pfx</PackageCertificateKeyFile>
<AppxPackageSigningEnabled>True</AppxPackageSigningEnabled>
<AppxGeneratePrisForPortableLibrariesEnabled>false</AppxGeneratePrisForPortableLibrariesEnabled>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|x86'">
<DebugSymbols>true</DebugSymbols>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
<ProjectTypeGuids>{A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
<WindowsXamlEnableOverview>true</WindowsXamlEnableOverview>
<AppxPackageSigningEnabled>false</AppxPackageSigningEnabled>
<AppxGeneratePrisForPortableLibrariesEnabled>false</AppxGeneratePrisForPortableLibrariesEnabled>
<LangVersion>7.0</LangVersion>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|x86'">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
<ProjectTypeGuids>{A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
<UnitTestPlatformVersion Condition="'$(UnitTestPlatformVersion)' == ''">$(VisualStudioVersion)</UnitTestPlatformVersion>
<AppxPackageSigningEnabled>false</AppxPackageSigningEnabled>
<AppxGeneratePrisForPortableLibrariesEnabled>false</AppxGeneratePrisForPortableLibrariesEnabled>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|x86'">
<DebugSymbols>true</DebugSymbols>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
<?xml version="1.0" encoding="utf-8"?>
<Project ToolsVersion="15.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
<PropertyGroup>
<SomeKey>SomeValue</SomeKey>
</PropertyGroup>
<PropertyGroup>
<Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
<Platform Condition=" '$(Platform)' == '' ">x86</Platform>
Expand All @@ -23,6 +20,7 @@
<PackageCertificateKeyFile><%=name%>_TemporaryKey.pfx</PackageCertificateKeyFile>
<%=certificateThumbprint%>
<PackageCertificatePassword>password</PackageCertificatePassword>
<AppxGeneratePrisForPortableLibrariesEnabled>false</AppxGeneratePrisForPortableLibrariesEnabled>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|x86'">
<DebugSymbols>true</DebugSymbols>
Expand Down