Skip to content

Conversation

@jonthysell
Copy link
Contributor

@jonthysell jonthysell commented Apr 6, 2020

With the new VMs, shaving down the current ~15min install step.

  • Updated the Install-VSFeatures.ps1 script:
    • If VS is already installed, defaults to using the local VS installer, rather than downloading the web installer
    • More output so you can track what's going on
    • When using the web installer, optionally cleanup downloaded files afterward
    • More cli parameters for more control of what goes where
    • Setting us up for Create a one-line command to install VS environment #4523
  • Updating the yamls to evaluate and pass parameters properly
  • Removing the need to run the installer at all, where necessary
  • Fixed the CLI so it correctly acknowledges the build agents have the right VS components, so it therefore finds MSBuild
    • Added more verbose logging to the MSBuild search
  • Added a task (disabled, but controlled via parameter) to list out all the VS components on the build agent, so we can debug missing dependencies faster

Closes #4450

Microsoft Reviewers: Open in CodeFlow

@jonthysell jonthysell requested a review from a team as a code owner April 6, 2020 23:53
@JunielKatarn
Copy link
Contributor

Changes seem fine, but out of curiosity:
How does adding verbosity increase the script's performance?

@jonthysell
Copy link
Contributor Author

jonthysell commented Apr 7, 2020

Changes seem fine, but out of curiosity:
How does adding verbosity increase the script's performance?

Sorry, this is an investigation / work-in progress. I'm first going to add more logging to the script so I can see where the time is being spent, and get a list of what is/isn't installed on the machines as part of the logging, then fine tune things.

@jonthysell jonthysell linked an issue Apr 7, 2020 that may be closed by this pull request
5 tasks
@jonthysell jonthysell merged commit f19904f into microsoft:master Apr 8, 2020
@jonthysell jonthysell deleted the reduceinstall branch April 8, 2020 01:54
);

if (verbose) {
console.log('Looking for MSBuilt at: ' + msBuildPath);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit spelling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only install what we need for the CI loop

4 participants