Consistency [with upstream] in instructions #4601
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All docs and upstream templates always prefix `react-native` invocations with `npx`.
NickGerleman
approved these changes
Apr 14, 2020
asklar
pushed a commit
to asklar/react-native-windows
that referenced
this pull request
Apr 19, 2020
* [generator] Use `npx` for consistency All docs and upstream templates always prefix `react-native` invocations with `npx`. * Change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very minor change to bring this in line with upstream instructions, which always prefix
react-nativewithnpx. E.g. https://github.com/react-native-community/cli/blob/04537d5693e6780c3f177fa5bfe21109b6b80fb3/packages/cli/src/commands/init/printRunInstructions.ts#L29PS: Wasn't sure if this needed a changelog entry, mostly because of the notion of it requiring a “pre-release”, which felt unnecessary to me 🤷♂️
Microsoft Reviewers: Open in CodeFlow